From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49236 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNqJe-0005Uw-6N for qemu-devel@nongnu.org; Wed, 01 Dec 2010 12:18:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNqJT-0002Bt-Rx for qemu-devel@nongnu.org; Wed, 01 Dec 2010 12:18:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3583) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNqJT-0002Bn-JX for qemu-devel@nongnu.org; Wed, 01 Dec 2010 12:17:51 -0500 Message-ID: <4CF6833B.7000103@redhat.com> Date: Wed, 01 Dec 2010 18:17:47 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <20101125170439.548474575@redhat.com> <20101125170602.676792336@redhat.com> <4CF665CE.70600@redhat.com> <20101201165821.GA13677@amt.cnet> In-Reply-To: <20101201165821.GA13677@amt.cnet> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [patch 2/2] support for UHCI suspend / remote wake up List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti Cc: Matthew Garrett , Adam Jackson , qemu-devel@nongnu.org, kvm , Glauber de Oliveira Costa > I was seeing bus disconnects when not clearing port resume bit properly. > >>> port->ctrl&= ~(val& 0x000a); >>> + port->ctrl&= ~(port->ctrl& 0x0040); /* clear port resume detected */ >>> } >> >> This chunk looks suspicious ... >> >> I suspect the port suspend/resume emulation isn't complete. The bug is that the port resume bit is masked out from guest writes, so the guest hasn't a chance to clear it ... cheers, Gerd PS: http://cgit.freedesktop.org/spice/qemu/log/?h=usb.1