From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57559 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNrFA-00033C-HX for qemu-devel@nongnu.org; Wed, 01 Dec 2010 13:17:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNrF8-0005IF-HL for qemu-devel@nongnu.org; Wed, 01 Dec 2010 13:17:28 -0500 Received: from e39.co.us.ibm.com ([32.97.110.160]:35991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNrF8-0005I0-Ac for qemu-devel@nongnu.org; Wed, 01 Dec 2010 13:17:26 -0500 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e39.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id oB1I5ntU009457 for ; Wed, 1 Dec 2010 11:05:49 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id oB1IHIGE261336 for ; Wed, 1 Dec 2010 11:17:18 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oB1IHGta003181 for ; Wed, 1 Dec 2010 11:17:18 -0700 Message-ID: <4CF6912A.8020206@linux.vnet.ibm.com> Date: Wed, 01 Dec 2010 10:17:14 -0800 From: "Venkateswararao Jujjuri (JV)" MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v5] virtio-9p: fix build on !CONFIG_UTIMENSAT References: <4CEC7A92.3080302@jp.fujitsu.com> <4CECC642.8090404@redhat.com> <4CF5A1DF.3050808@jp.fujitsu.com> In-Reply-To: <4CF5A1DF.3050808@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hidetoshi Seto Cc: Blue Swirl , "kvm@vger.kernel.org" , Philipp Hahn , Jes Sorensen , "Hao, Xudong" , "qemu-devel@nongnu.org" , Chris Wright , "M. Mohan Kumar" , Avi Kivity On 11/30/2010 5:16 PM, Hidetoshi Seto wrote: > Ping. > > Maintainers, please tell me if still something is required for > this patch before applying it. With Jes's Ack it should be good to go. I will included it in my next pull request to Anthony..and during that time if I see any issues I will let you know. Thanks for working on it. JV. > > > Thanks, > H.Seto > > (2010/11/24 17:01), Jes Sorensen wrote: >> On 11/24/10 03:38, Hidetoshi Seto wrote: >>> This patch introduce a fallback mechanism for old systems that do not >>> support utimensat(). This fix build failure with following warnings: >>> >>> hw/virtio-9p-local.c: In function 'local_utimensat': >>> hw/virtio-9p-local.c:479: warning: implicit declaration of function 'utimensat' >>> hw/virtio-9p-local.c:479: warning: nested extern declaration of 'utimensat' >>> >>> and: >>> >>> hw/virtio-9p.c: In function 'v9fs_setattr_post_chmod': >>> hw/virtio-9p.c:1410: error: 'UTIME_NOW' undeclared (first use in this function) >>> hw/virtio-9p.c:1410: error: (Each undeclared identifier is reported only once >>> hw/virtio-9p.c:1410: error: for each function it appears in.) >>> hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this function) >>> hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod': >>> hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this function) >>> >>> [NOTE: At this time virtio-9p is only user of utimensat(), and is available >>> only when host is linux and CONFIG_VIRTFS is defined. So there are >>> no similar warning for win32. Please provide a wrapper for win32 in >>> oslib-win32.c if new user really requires it.] >>> >>> v5: >>> - Allow fallback on runtime >>> - Move qemu_utimensat() to oslib-posix.c >>> - Rebased on latest qemu.git >>> v4: >>> - Use tv_now.tv_usec >>> v3: >>> - Use better alternative handling for UTIME_NOW/OMIT >>> - Move qemu_utimensat() to cutils.c >>> V2: >>> - Introduce qemu_utimensat() >>> >>> Acked-by: Chris Wright >>> Acked-by: M. Mohan Kumar >>> Signed-off-by: Hidetoshi Seto >>> --- >>> hw/virtio-9p-local.c | 4 ++-- >>> oslib-posix.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ >>> qemu-os-posix.h | 12 ++++++++++++ >>> 3 files changed, 62 insertions(+), 2 deletions(-) >> >> Hi Hidetoshi, >> >> This looks good to me! >> >> Acked-by: Jes Sorensen >> >> Cheers, >> Jes > >