From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59307 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1POsMW-0003bL-IT
	for qemu-devel@nongnu.org; Sat, 04 Dec 2010 08:41:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1POsMU-0001hV-Bn
	for qemu-devel@nongnu.org; Sat, 04 Dec 2010 08:41:16 -0500
Received: from mail-bw0-f45.google.com ([209.85.214.45]:53242)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1POsMU-0001hJ-3T
	for qemu-devel@nongnu.org; Sat, 04 Dec 2010 08:41:14 -0500
Received: by bwz16 with SMTP id 16so9429367bwz.4
	for <qemu-devel@nongnu.org>; Sat, 04 Dec 2010 05:41:13 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4CFA44FB.8000200@redhat.com>
Date: Sat, 04 Dec 2010 14:41:15 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1291373374-10296-1-git-send-email-glommer@redhat.com>
	<1291373374-10296-3-git-send-email-glommer@redhat.com>
In-Reply-To: <1291373374-10296-3-git-send-email-glommer@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/2] Do not register kvmclock savevm
 section if kvmclock is disabled.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: mtosatti@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, avi@redhat.com

On 12/03/2010 11:49 AM, Glauber Costa wrote:
> +/* This has to happen after vcpu setup*/
> +void kvmclock_register_savevm(void)
> +{
> +#ifdef KVM_CAP_ADJUST_CLOCK
> +    if (kvmclock_enabled&&  kvm_check_extension(kvm_state, KVM_CAP_ADJUST_CLOCK)) {
> +        printf("registering kvmclock savevm section\n");
> +        vmstate_register(NULL, 0,&vmstate_kvmclock,&kvmclock_data);
> +    }
> +#endif
> +}
> +

You should use a state change notifier for patch 1.  Even better, if you 
put this patch first adding the state change notifier will be very clean.

Paolo