From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39741 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPW0X-0000Kv-Uj for qemu-devel@nongnu.org; Mon, 06 Dec 2010 03:01:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PPW0W-0003Ny-OE for qemu-devel@nongnu.org; Mon, 06 Dec 2010 03:01:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PPW0W-0003NS-Hd for qemu-devel@nongnu.org; Mon, 06 Dec 2010 03:01:12 -0500 Message-ID: <4CFC9840.4080604@redhat.com> Date: Mon, 06 Dec 2010 09:01:04 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/3] Fail if detecting an unknown option References: <1291312009-24351-1-git-send-email-Jes.Sorensen@redhat.com> <1291312009-24351-4-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, qemu-devel@nongnu.org On 12/03/10 12:46, Stefan Hajnoczi wrote: > On Thu, Dec 2, 2010 at 5:46 PM, wrote: >> From: Jes Sorensen >> >> This patch changes qemu-img to exit if an unknown option is detected, >> instead of trying to continue with a set of arguments which may be >> incorrect. >> >> Signed-off-by: Jes Sorensen >> --- >> qemu-img.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 files changed, 48 insertions(+), 0 deletions(-) > > Do we get a silent exit if an unknown option is detected? Normally > programs print their help/usage when this happens. > > Stefan Fixed in the next version :) Cheers, Jes