From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 4/7] Make error handling more consistent in img_create() and img_resize()
Date: Mon, 06 Dec 2010 16:32:56 +0100 [thread overview]
Message-ID: <4CFD0228.3030001@redhat.com> (raw)
In-Reply-To: <4CFD0060.7030700@redhat.com>
On 12/06/10 16:25, Kevin Wolf wrote:
>> }
>> n = get_option_parameter(param, BLOCK_OPT_SIZE)->value.n;
>> free_option_parameters(param);
>>
>> bs = bdrv_new_open(filename, fmt, BDRV_O_FLAGS | BDRV_O_RDWR);
>> if (!bs) {
>> - return 1;
>> + ret = -1;
>> + goto out;
>> }
>
> Same here.
>
> Heh, wanted to try it out to be sure, but the compiler notices that, so
> it doesn't even build:
Grrrrr I am an idiot!
Sorry about the noise, I was sure I had tested that last change. Fix
coming up in a few minutes.
Cheers,
Jes
next prev parent reply other threads:[~2010-12-06 15:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 14:25 [Qemu-devel] [PATCH v3 0/7] Cleanup qemu-img code Jes.Sorensen
2010-12-06 14:25 ` [Qemu-devel] [PATCH 1/7] Add missing tracing to qemu_mallocz() Jes.Sorensen
2010-12-06 14:42 ` [Qemu-devel] " Stefan Hajnoczi
2010-12-06 14:25 ` [Qemu-devel] [PATCH 2/7] Use qemu_mallocz() instead of calloc() in img_convert() Jes.Sorensen
2010-12-06 14:43 ` [Qemu-devel] " Stefan Hajnoczi
2010-12-06 14:25 ` [Qemu-devel] [PATCH 3/7] img_convert(): Only try to free bs[] entries if bs is valid Jes.Sorensen
2010-12-06 14:44 ` [Qemu-devel] " Stefan Hajnoczi
2010-12-06 14:25 ` [Qemu-devel] [PATCH 4/7] Make error handling more consistent in img_create() and img_resize() Jes.Sorensen
2010-12-06 14:58 ` [Qemu-devel] " Stefan Hajnoczi
2010-12-06 15:25 ` Kevin Wolf
2010-12-06 15:32 ` Jes Sorensen [this message]
2010-12-06 14:25 ` [Qemu-devel] [PATCH 5/7] Consolidate printing of block driver options Jes.Sorensen
2010-12-06 14:59 ` [Qemu-devel] " Stefan Hajnoczi
2010-12-06 14:25 ` [Qemu-devel] [PATCH 6/7] Fix formatting and missing braces in qemu-img.c Jes.Sorensen
2010-12-06 15:00 ` [Qemu-devel] " Stefan Hajnoczi
2010-12-06 14:25 ` [Qemu-devel] [PATCH 7/7] Fail if detecting an unknown option Jes.Sorensen
2010-12-06 15:02 ` [Qemu-devel] " Stefan Hajnoczi
2010-12-06 15:33 ` [Qemu-devel] Re: [PATCH v3 0/7] Cleanup qemu-img code Kevin Wolf
-- strict thread matches above, loose matches on Subject: below --
2010-12-06 15:45 [Qemu-devel] [PATCH 4/7] Make error handling more consistent in img_create() and img_resize() Jes.Sorensen
2010-12-06 15:57 ` [Qemu-devel] " Kevin Wolf
2010-12-06 15:57 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFD0228.3030001@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).