From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57034 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PPd3k-0001h3-I1
	for qemu-devel@nongnu.org; Mon, 06 Dec 2010 10:33:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PPd3j-0008JN-Ex
	for qemu-devel@nongnu.org; Mon, 06 Dec 2010 10:33:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:22870)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PPd3j-0008JG-6t
	for qemu-devel@nongnu.org; Mon, 06 Dec 2010 10:32:59 -0500
Message-ID: <4CFD0228.3030001@redhat.com>
Date: Mon, 06 Dec 2010 16:32:56 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <1291645540-9784-1-git-send-email-Jes.Sorensen@redhat.com>
	<1291645540-9784-5-git-send-email-Jes.Sorensen@redhat.com>
	<4CFD0060.7030700@redhat.com>
In-Reply-To: <4CFD0060.7030700@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 4/7] Make error handling more consistent in
 img_create() and img_resize()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org

On 12/06/10 16:25, Kevin Wolf wrote:
>>      }
>>      n = get_option_parameter(param, BLOCK_OPT_SIZE)->value.n;
>>      free_option_parameters(param);
>>  
>>      bs = bdrv_new_open(filename, fmt, BDRV_O_FLAGS | BDRV_O_RDWR);
>>      if (!bs) {
>> -        return 1;
>> +        ret = -1;
>> +        goto out;
>>      }
> 
> Same here.
> 
> Heh, wanted to try it out to be sure, but the compiler notices that, so
> it doesn't even build:

Grrrrr I am an idiot!

Sorry about the noise, I was sure I had tested that last change. Fix
coming up in a few minutes.

Cheers,
Jes