From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59992 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PPdRm-0002Ob-6R
	for qemu-devel@nongnu.org; Mon, 06 Dec 2010 10:57:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PPdRl-0005lc-6o
	for qemu-devel@nongnu.org; Mon, 06 Dec 2010 10:57:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43407)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PPdRl-0005lT-02
	for qemu-devel@nongnu.org; Mon, 06 Dec 2010 10:57:49 -0500
Message-ID: <4CFD07EF.1000206@redhat.com>
Date: Mon, 06 Dec 2010 16:57:35 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <1291650325-10968-1-git-send-email-Jes.Sorensen@redhat.com>
	<4CFD07F1.1040108@redhat.com>
In-Reply-To: <4CFD07F1.1040108@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 4/7] Make error handling more consistent in
 img_create() and img_resize()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org

On 12/06/10 16:57, Kevin Wolf wrote:
> bdrv_delete doesn't check for NULL, so this still isn't enough. Try
> something like "qemu-img resize -f vmdx foo +0" and you'll get a segfault.

Grrrr :(

It's a bummer things are so inconsistent throughout QEMU, most of the
free() functions can handle it.

Updated patch in a minute - sorry.

Thanks,
Jes