From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57777 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPyXk-0002a0-CZ for qemu-devel@nongnu.org; Tue, 07 Dec 2010 09:29:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PPyXa-0001Kq-AJ for qemu-devel@nongnu.org; Tue, 07 Dec 2010 09:29:24 -0500 Received: from e1.ny.us.ibm.com ([32.97.182.141]:42090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PPyXa-0001KX-7u for qemu-devel@nongnu.org; Tue, 07 Dec 2010 09:29:14 -0500 Received: from d01dlp02.pok.ibm.com (d01dlp02.pok.ibm.com [9.56.224.85]) by e1.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id oB7EL4d3005689 for ; Tue, 7 Dec 2010 09:21:04 -0500 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id ED9334DE803B for ; Tue, 7 Dec 2010 09:27:21 -0500 (EST) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oB7ETCGc405682 for ; Tue, 7 Dec 2010 09:29:12 -0500 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oB7ETBQK027242 for ; Tue, 7 Dec 2010 09:29:11 -0500 Message-ID: <4CFE44B6.10307@linux.vnet.ibm.com> Date: Tue, 07 Dec 2010 08:29:10 -0600 From: Michael Roth MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [RFC][PATCH v5 00/21] virtagent: host/guest RPC communication agent References: <1291399402-20366-1-git-send-email-mdroth@linux.vnet.ibm.com> <4CFE0B5F.3080301@redhat.com> In-Reply-To: <4CFE0B5F.3080301@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, abeekhof@redhat.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com On 12/07/2010 04:24 AM, Jes Sorensen wrote: > On 12/03/10 19:03, Michael Roth wrote: >> These patches apply to master, and can also be obtained from: >> git://repo.or.cz/qemu/mdroth.git virtagent_v5 >> >> CHANGES IN V5: >> >> - Dependency on virtproxy dropped, virtagent now handles transport and multiplexing of bi-directional RPCs internally >> - Removed duplification of qemu_set_fd_handler()-centered i/o code. Support for interacting with objects that use qemu_set_fd_handler() now available to tools via qemu-tools.c and a set of generalized utility functions >> - Fixed memory leaks in client/monitor functions >> - Various cleanups > > Hi Michael, > > Does this mean that virtproxy is now obsolete, or does it just mean > using virtproxy is optional? > As far as virtagent goes it is obsolete, and without the guest-side bits of virtproxy being integrated into the guest agent I don't see it being very useful at this point. > I would still prefer to have virtagent a separate package, rather than > part of the QEMU tree though. There's a client and server in qemu, and a client and server in the agent, and all that code is shared. So even if we were to have a seperate tree for the agent, 90% of the code would also be sitting in the qemu tree anyway. I wouldn't mind hosting it outside of qemu but given what we're trying to do there's not a whole lot to be gained from it. I agree it'd make sense if virtagent wasn't bidirectional since then there'd be a clean separation between qemu (client) and virtagent (server), and it would have the added benefit of enforcing consistent/stable client/server APIs between versions, but that's not the case here. > > Thanks, > Jes > >