qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"David S. Ahern" <daahern@cisco.com>
Subject: Re: [Qemu-devel] State of EHCI emulation for QEMU
Date: Wed, 08 Dec 2010 09:24:50 +0100	[thread overview]
Message-ID: <4CFF40D2.9020605@web.de> (raw)
In-Reply-To: <4CFF3F48.800@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]

Am 08.12.2010 09:18, Gerd Hoffmann wrote:
>   Hi,
> 
>> - command line must look like this:
>>          ...
>>          -drive if=none,id=usbstick,file=/path/to/image   \
>>          -device usb-storage,bus=ehci.0,drive=usbstick
>>    ie. register driver device referencing it, and there was a typo id->if
> 
> I'll fix.
> 
>> - long-term, "-usb" should become a shorthand for "-device
>>    usb-uhci,id=uhci -device usb-ehci,id=ehci" (at least for x86)
> 
> Hmm, I'd tend to leave '-M pc' as-is and enable ehci by default in the
> upcoming q35 emulation, especially in case both make it into 0.15.

I'm was concerned about the semantic of -usb. If ehci&uhci is going to
be on by default in the future, we should obsolete and finally drop this
switch.

> 
>> Unfortunately, msd is not yet magically healed:
>>
>>    non queue head request in async schedule
>>    processing error - resetting ehci HC
> 
> Yea, I've seen a flaw in async handling.  Just need to dig some more
> into the code to fix it properly, also the packet workflow (including
> async handling) is one of the spots where the qemu usb subsystem needs
> some work ...
> 
>> PS: Your tree lacks conversion of usb-musb.c.
> 
> Huh?  'git diff kiszka/master kiszka/ehci hw/usb-musb.c' is empty.

The breakage comes from one of your patches. Just try to build an ARM
target.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

      reply	other threads:[~2010-12-08  8:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-13 19:28 [Qemu-devel] State of EHCI emulation for QEMU Jan Kiszka
2010-12-04  0:18 ` Gerd Hoffmann
2010-12-04  9:05   ` Jan Kiszka
2010-12-04 20:21     ` David S. Ahern
2010-12-08  8:26       ` Gerd Hoffmann
2010-12-08  8:32         ` Jan Kiszka
2010-12-08 15:49           ` David S. Ahern
2010-12-08 17:14             ` Gerd Hoffmann
2010-12-08 17:41               ` David Ahern (daahern)
2010-12-09 13:05                 ` Gerd Hoffmann
2010-12-09 20:32                   ` David S. Ahern
2010-12-11 10:42                     ` Blue Swirl
2010-12-08  8:18     ` Gerd Hoffmann
2010-12-08  8:24       ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CFF40D2.9020605@web.de \
    --to=jan.kiszka@web.de \
    --cc=Jes.Sorensen@redhat.com \
    --cc=daahern@cisco.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).