From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] qemu-img.c: Clean up handling of image size in img_create()
Date: Wed, 08 Dec 2010 10:14:20 +0100 [thread overview]
Message-ID: <4CFF4C6C.70202@redhat.com> (raw)
In-Reply-To: <4CFF47B0.1030906@redhat.com>
On 12/08/10 09:54, Kevin Wolf wrote:
> Am 07.12.2010 21:36, schrieb Stefan Hajnoczi:
>> Today it is possible to create 0 byte sized images. Your patch will
>> change that:
>> If there is a backing file, then the size will be taken from the backing file.
>> If there is no backing file, then an error about missing size will be
>> printed, even though a size of 0 has been given.
>
> I can think of one use case for it: You can store the VM state on a
> zero-sized qcow2 image for internal snapshots.
>
> Otherwise it's probably rather useless, but we have supported it for a
> long time, so I wouldn't remove it. People have actually noticed in the
> past when something was broken with it.
Ok that is fair, I have just posted an updated version which should do
the right thing. Shows up it made the patch even simpler :)
Cheers,
Jes
prev parent reply other threads:[~2010-12-08 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 17:39 [Qemu-devel] [PATCH 1/1] qemu-img.c: Clean up handling of image size in img_create() Jes.Sorensen
2010-12-07 20:36 ` Stefan Hajnoczi
2010-12-08 6:30 ` Jes Sorensen
2010-12-08 8:54 ` Kevin Wolf
2010-12-08 9:14 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFF4C6C.70202@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).