From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46725 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PQGLg-0007YL-0d
	for qemu-devel@nongnu.org; Wed, 08 Dec 2010 04:30:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PQGLe-0000dF-6B
	for qemu-devel@nongnu.org; Wed, 08 Dec 2010 04:30:07 -0500
Received: from mx1.redhat.com ([209.132.183.28]:18699)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PQGLd-0000cx-Vf
	for qemu-devel@nongnu.org; Wed, 08 Dec 2010 04:30:06 -0500
Message-ID: <4CFF5008.3030407@redhat.com>
Date: Wed, 08 Dec 2010 10:29:44 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd
	handlers into utility functions
References: <1291399402-20366-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1291399402-20366-2-git-send-email-mdroth@linux.vnet.ibm.com>
	<4CFE3738.4010506@redhat.com> <4CFE4928.5000409@linux.vnet.ibm.com>
	<4CFE4C6B.1010600@redhat.com>
	<20101208091513.GA5974@stefanha-thinkpad.localdomain>
	<4CFF4D3E.5080202@redhat.com>
	<20101208092321.GB5974@stefanha-thinkpad.localdomain>
In-Reply-To: <20101208092321.GB5974@stefanha-thinkpad.localdomain>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: agl@linux.vnet.ibm.com, abeekhof@redhat.com, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com

On 12/08/10 10:23, Stefan Hajnoczi wrote:
> From 7.1.3 Reserved identifiers:
> 
> "All identifiers that begin with an underscore and either an uppercase
> letter or another underscore are always reserved for any use."
> 
> and
> 
> "All identifiers that begin with an underscore are always reserved for
> use as identifiers with file scope in both the ordinary and tag name
> spaces."
> 
> That includes three or more underscores too.

Ok, I never hit problems with this, but ok we can name it
do_qemu_set_fd_handler() instead. That would go with the existing naming
conventions used in many places throughout the code.

Cheers,
Jes