From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/3] block: Introduce path_has_protocol() function
Date: Thu, 09 Dec 2010 11:59:26 +0100 [thread overview]
Message-ID: <4D00B68E.2050400@redhat.com> (raw)
In-Reply-To: <1291130056-32441-3-git-send-email-stefanha@linux.vnet.ibm.com>
Am 30.11.2010 16:14, schrieb Stefan Hajnoczi:
> The bdrv_find_protocol() function returns NULL if an unknown protocol
> name is given. It returns the "file" protocol when the filename
> contains no protocol at all. This makes it difficult to distinguish
> between paths which contain a protocol and those which do not.
>
> Factor out a helper function that tests whether or not a filename has a
> protocol. The next patch makes use of this function.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
This breaks the mingw32 build:
/home/kwolf/tmp/win32/qemu/block.c: In function 'path_has_protocol':
/home/kwolf/tmp/win32/qemu/block.c:78: warning: implicit declaration of
function 'is_windows_drive_prefix'
/home/kwolf/tmp/win32/qemu/block.c:78: warning: nested extern
declaration of 'is_windows_drive_prefix'
/home/kwolf/tmp/win32/qemu/block.c: At top level:
/home/kwolf/tmp/win32/qemu/block.c:261: error: static declaration of
'is_windows_drive_prefix' follows non-static declaration
/home/kwolf/tmp/win32/qemu/block.c:78: note: previous implicit
declaration of 'is_windows_drive_prefix' was here
Kevin
next prev parent reply other threads:[~2010-12-09 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 15:14 [Qemu-devel] [PATCH 0/3] block: Fix the use of protocols in backing files Stefan Hajnoczi
2010-11-30 15:14 ` [Qemu-devel] [PATCH 1/3] block: Make bdrv_create_file() ':' handling consistent Stefan Hajnoczi
2010-11-30 15:14 ` [Qemu-devel] [PATCH 2/3] block: Introduce path_has_protocol() function Stefan Hajnoczi
2010-12-09 10:59 ` Kevin Wolf [this message]
2010-11-30 15:14 ` [Qemu-devel] [PATCH 3/3] block: Fix the use of protocols in backing files Stefan Hajnoczi
2010-12-02 14:31 ` [Qemu-devel] " Kevin Wolf
2010-12-02 15:48 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D00B68E.2050400@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).