From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37711 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQgMk-0006vH-TK for qemu-devel@nongnu.org; Thu, 09 Dec 2010 08:16:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQgMj-00084e-8z for qemu-devel@nongnu.org; Thu, 09 Dec 2010 08:16:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQgMj-00084R-0u for qemu-devel@nongnu.org; Thu, 09 Dec 2010 08:16:57 -0500 Message-ID: <4D00D6C3.50103@redhat.com> Date: Thu, 09 Dec 2010 14:16:51 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1290795203-2597-1-git-send-email-hdegoede@redhat.com> In-Reply-To: <1290795203-2597-1-git-send-email-hdegoede@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/7] usb-linux: introduce a usb_linux_alt_setting function List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: spice-devel@lists.freedesktop.org, qemu-devel@nongnu.org On 11/26/10 19:13, Hans de Goede wrote: > The next patch in this series introduces multiple ways to get the > alt setting dependent upon usb_fs_type, it is cleaner to put this > into its own function. > > Note that this patch also changes the assumed alt setting in case > of an error getting the alt setting to be 0 (a sane default) rather > then the interface numberwhich makes no sense. Patch series looks good. Acked-by: Gerd Hoffmann cheers, Gerd