From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40834 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQwkY-0006er-Et for qemu-devel@nongnu.org; Fri, 10 Dec 2010 01:46:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQwkW-0001s5-SP for qemu-devel@nongnu.org; Fri, 10 Dec 2010 01:46:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQwkW-0001s1-Jx for qemu-devel@nongnu.org; Fri, 10 Dec 2010 01:46:36 -0500 Message-ID: <4D01CCC3.8020301@redhat.com> Date: Fri, 10 Dec 2010 07:46:27 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [RFC][PATCH v5 09/21] virtagent: add va.getdmesg RPC References: <1291399402-20366-1-git-send-email-mdroth@linux.vnet.ibm.com> <1291399402-20366-10-git-send-email-mdroth@linux.vnet.ibm.com> <4CFE4699.5070000@redhat.com> <4CFE6F94.7090208@linux.vnet.ibm.com> <4CFFDB13.2010609@redhat.com> <4D0146DE.70300@linux.vnet.ibm.com> In-Reply-To: <4D0146DE.70300@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, abeekhof@redhat.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com On 12/09/10 22:15, Michael Roth wrote: > On 12/08/2010 01:22 PM, Jes Sorensen wrote: >>> This param is kind of quirky though, size doesn't seem to have an affect >>> for anything below 4KB, but if we stick with VA_DMESG_LEN>= 4KB this >>> should cover us, unless it's a distro-specific. But it should blow >>> anything up, at least. >> >> I am wary of these hard coded constants. Isn't there a way to set the >> kernel's dmesg buffer size, or is that only a compile time option? >> > > From what I can tell it's a compile-time option. I originally had > dmesg_len as a param the host could pass to the guest, but it has no > effect if the buffer is smaller, which might cause unnecessary confusion. You are correct! I checked, there were people talking about a configurable option but so far it is not in place. I would still rather have this go via a file transfer to the host, and put the output in a tmpfile. I am still against adding viewfile commands to the monitor though. You get a bad control character in the string and your console is messed up. Hit CTRL-c and you lost your guest. Cheers, Jes