From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44989 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PS4Qe-0007RP-OG for qemu-devel@nongnu.org; Mon, 13 Dec 2010 04:10:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PS4Qd-0007A6-17 for qemu-devel@nongnu.org; Mon, 13 Dec 2010 04:10:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PS4Qc-00079q-LL for qemu-devel@nongnu.org; Mon, 13 Dec 2010 04:10:42 -0500 Message-ID: <4D05E30E.20309@redhat.com> Date: Mon, 13 Dec 2010 11:10:38 +0200 From: Avi Kivity MIME-Version: 1.0 References: <20101208170858.GA10056@amt.cnet> <4D032AB2.6080201@redhat.com> <20101213000017.GA8265@amt.cnet> <4D05DC35.8030009@redhat.com> <20101213084932.GZ15610@redhat.com> <4D05DEF3.60608@redhat.com> <20101213090359.GA15610@redhat.com> In-Reply-To: <20101213090359.GA15610@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: Marcelo Tosatti , seabios@seabios.org, qemu-devel@nongnu.org On 12/13/2010 11:03 AM, Gleb Natapov wrote: > > We could also deprecate the old port and use fwcfg for everything > > (try fwcfg, fall back to ae00). > > > fwcfg designed to be simple for easy use by firmware. It has two port > one for index another for value, so its use is racy in multi-threaded SMP > environment. DSDT code is executed in such environment. There is lock > facility in AML, but why complicate things. I prefer to remove complexity from interfaces and have it in the implementation instead. > > >> We could do this in two ways: by adding a fwcfg client to the DSDT, > > >> or by copying the information to system memory, and referencing > > >> system memory from the DSDT. > > >> > > >This is even worse. It requires some fixed address to be shared between > > >DSDT and Seabios (or alternatively Seabios will have to generate this > > >part of DSDT dynamically). > > > > > > > Could easily be something in the F segment. > > > Yes, but then we will have two magic values (fwcfg index + address > in F segment) instead of one (address of pci hot-plug controller). The F segment address is internal to SeaBIOS; it isn't an external interface. -- error compiling committee.c: too many arguments to function