From: Avi Kivity <avi@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH v4 2/2] RAM API: Make use of it for x86 PC
Date: Tue, 14 Dec 2010 11:18:25 +0200 [thread overview]
Message-ID: <4D073661.8010307@redhat.com> (raw)
In-Reply-To: <20101213212436.2472.16686.stgit@s20.home>
On 12/13/2010 11:24 PM, Alex Williamson wrote:
> Register the actual VM RAM using the new API
>
>
> @@ -913,14 +913,11 @@ void pc_memory_init(ram_addr_t ram_size,
> /* allocate RAM */
> ram_addr = qemu_ram_alloc(NULL, "pc.ram",
> below_4g_mem_size + above_4g_mem_size);
> - cpu_register_physical_memory(0, 0xa0000, ram_addr);
> - cpu_register_physical_memory(0x100000,
> - below_4g_mem_size - 0x100000,
> - ram_addr + 0x100000);
> + ram_register(0, below_4g_mem_size, ram_addr);
>
What's the impact of this? Won't it conflict with BIOS memory
registration? What about VGA?
In terms of patch hygiene, it should be in a separate patch titled
"register 0xa0000-0x100000 as RAM" or something. It's a much more
drastic change than making use of the new RAM API.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-12-14 9:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 21:24 [Qemu-devel] [PATCH v4 0/2] Minimal RAM API support Alex Williamson
2010-12-13 21:24 ` [Qemu-devel] [PATCH v4 1/2] " Alex Williamson
2010-12-15 17:23 ` Paul Brook
2010-12-15 19:11 ` Alex Williamson
2010-12-15 19:34 ` Anthony Liguori
2010-12-13 21:24 ` [Qemu-devel] [PATCH v4 2/2] RAM API: Make use of it for x86 PC Alex Williamson
2010-12-14 9:18 ` Avi Kivity [this message]
2010-12-14 15:16 ` [Qemu-devel] " Alex Williamson
2010-12-14 15:18 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D073661.8010307@redhat.com \
--to=avi@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).