From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42644 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PSR1q-00005Q-Tb for qemu-devel@nongnu.org; Tue, 14 Dec 2010 04:18:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PSR1p-0001oa-HP for qemu-devel@nongnu.org; Tue, 14 Dec 2010 04:18:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PSR1p-0001kL-AF for qemu-devel@nongnu.org; Tue, 14 Dec 2010 04:18:37 -0500 Message-ID: <4D073661.8010307@redhat.com> Date: Tue, 14 Dec 2010 11:18:25 +0200 From: Avi Kivity MIME-Version: 1.0 References: <20101213212059.2472.17879.stgit@s20.home> <20101213212436.2472.16686.stgit@s20.home> In-Reply-To: <20101213212436.2472.16686.stgit@s20.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v4 2/2] RAM API: Make use of it for x86 PC List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org, kvm@vger.kernel.org On 12/13/2010 11:24 PM, Alex Williamson wrote: > Register the actual VM RAM using the new API > > > @@ -913,14 +913,11 @@ void pc_memory_init(ram_addr_t ram_size, > /* allocate RAM */ > ram_addr = qemu_ram_alloc(NULL, "pc.ram", > below_4g_mem_size + above_4g_mem_size); > - cpu_register_physical_memory(0, 0xa0000, ram_addr); > - cpu_register_physical_memory(0x100000, > - below_4g_mem_size - 0x100000, > - ram_addr + 0x100000); > + ram_register(0, below_4g_mem_size, ram_addr); > What's the impact of this? Won't it conflict with BIOS memory registration? What about VGA? In terms of patch hygiene, it should be in a separate patch titled "register 0xa0000-0x100000 as RAM" or something. It's a much more drastic change than making use of the new RAM API. -- error compiling committee.c: too many arguments to function