From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41628 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PSXI9-0007VW-3a for qemu-devel@nongnu.org; Tue, 14 Dec 2010 10:59:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PSXI5-00077y-79 for qemu-devel@nongnu.org; Tue, 14 Dec 2010 10:59:52 -0500 Received: from mail-ey0-f181.google.com ([209.85.215.181]:34591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PSXI4-00077I-PP for qemu-devel@nongnu.org; Tue, 14 Dec 2010 10:59:49 -0500 Received: by eyh6 with SMTP id 6so405909eyh.12 for ; Tue, 14 Dec 2010 07:59:47 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4D07947B.80702@redhat.com> Date: Tue, 14 Dec 2010 16:59:55 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1292262202.2857.114.camel@x201> <20101213175010.GD7182@redhat.com> <1292263244.2857.120.camel@x201> <20101213185437.GB9554@redhat.com> <1292266756.2857.122.camel@x201> <20101213190619.GD9554@redhat.com> <1292267708.2857.123.camel@x201> <20101214044342.GE9554@redhat.com> <1292302848.2857.148.camel@x201> <20101214123209.GC19950@redhat.com> <1292341315.2857.175.camel@x201> In-Reply-To: <1292341315.2857.175.camel@x201> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: quintela@redhat.com, qemu-devel@nongnu.org, "Michael S. Tsirkin" On 12/14/2010 04:41 PM, Alex Williamson wrote: > > Maybe in this particular case the advantage is minimal. > > But it seems easier to stick to a rule of no more version > > bumps than argue about each case. > > Do we have such a rule? If we have a subsection who's needed function > is return 1, I think that's a good indication that it's not appropriate > for a subsection and the end result is equivalent to bumping the main > driver vmstate version. It's convoluted to try to hide a one-way > upgrade in a subsection. Thanks, Indeed, subsections are for data that is rarely needed so that there's some chance (sometimes ~100%) of migration working seemlessly. In this case it's either no-bump-and-live-with-the-consequences, or changing the version id. Paolo