From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37621 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PSqSE-00026i-2X for qemu-devel@nongnu.org; Wed, 15 Dec 2010 07:27:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PSqSC-0005lA-T0 for qemu-devel@nongnu.org; Wed, 15 Dec 2010 07:27:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PSqSC-0005l6-Jv for qemu-devel@nongnu.org; Wed, 15 Dec 2010 07:27:32 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBFCRV3K002871 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 15 Dec 2010 07:27:31 -0500 Message-ID: <4D08B430.1000600@redhat.com> Date: Wed, 15 Dec 2010 13:27:28 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/5] ccid: add passthru card device References: <1292179059-21617-1-git-send-email-alevy@redhat.com> <1292179059-21617-3-git-send-email-alevy@redhat.com> In-Reply-To: <1292179059-21617-3-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org Hi, Commit message could be a bit more verbose, even if it is redundant with what the patch "1/5" message says. Also short usage information (or pointer to the file patch "5/5" adds) would be good. Patch itself looks fine to me. cheers, Gerd