From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33185 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PSqWa-0003Y0-VS for qemu-devel@nongnu.org; Wed, 15 Dec 2010 07:32:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PSqWZ-0006m2-VW for qemu-devel@nongnu.org; Wed, 15 Dec 2010 07:32:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PSqWZ-0006lx-Mj for qemu-devel@nongnu.org; Wed, 15 Dec 2010 07:32:03 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBFCW2BP031918 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 15 Dec 2010 07:32:03 -0500 Message-ID: <4D08B540.3030101@redhat.com> Date: Wed, 15 Dec 2010 13:32:00 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/5] libcacard: initial commit after coding style fixes References: <1292179059-21617-1-git-send-email-alevy@redhat.com> <1292179059-21617-4-git-send-email-alevy@redhat.com> In-Reply-To: <1292179059-21617-4-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On 12/12/10 19:37, Alon Levy wrote: > From: Robert Relyea > > Signed-off-by: Alon Levy Commit message could be more verbose too. This is the smart card emulation library, right? Patch looks good on a quick glance, I'm not a crypto expert though. Acked-by: Gerd Hoffmann cheers, Gerd