From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45533 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PSqbn-0005Od-Sn for qemu-devel@nongnu.org; Wed, 15 Dec 2010 07:37:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PSqbm-0007lz-Vs for qemu-devel@nongnu.org; Wed, 15 Dec 2010 07:37:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PSqbm-0007lr-NH for qemu-devel@nongnu.org; Wed, 15 Dec 2010 07:37:26 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBFCbPbm004255 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 15 Dec 2010 07:37:26 -0500 Message-ID: <4D08B683.6030407@redhat.com> Date: Wed, 15 Dec 2010 13:37:23 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 4/5] ccid: add ccid-card-emulated device (v2) References: <1292179059-21617-1-git-send-email-alevy@redhat.com> <1292179059-21617-5-git-send-email-alevy@redhat.com> In-Reply-To: <1292179059-21617-5-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On 12/12/10 19:37, Alon Levy wrote: > changes from v1: > remove stale comments, use only c-style comments > bugfix, forgot to set recv_len > change reader name to 'Virtual Reader' > > Signed-off-by: Alon Levy Should be more verbose too. Please explain what the threads are used for and why they are needed (/me guesses that libcacard wants run async). thanks, Gerd