From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39043 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PSuZj-0004q8-IY
	for qemu-devel@nongnu.org; Wed, 15 Dec 2010 11:51:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PSuZi-000788-Du
	for qemu-devel@nongnu.org; Wed, 15 Dec 2010 11:51:35 -0500
Received: from mx1.redhat.com ([209.132.183.28]:11893)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PSuZi-00077l-4z
	for qemu-devel@nongnu.org; Wed, 15 Dec 2010 11:51:34 -0500
Message-ID: <4D08F25C.2010103@redhat.com>
Date: Wed, 15 Dec 2010 17:52:44 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1292225579-27320-1-git-send-email-Jes.Sorensen@redhat.com>
In-Reply-To: <1292225579-27320-1-git-send-email-Jes.Sorensen@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/3] Re-factor img_create() and add live
	snapshots
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org, armbru@redhat.com, stefanha@linux.vnet.ibm.com

Am 13.12.2010 08:32, schrieb Jes.Sorensen@redhat.com:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
> 
> Hi,
> 
> This set of patches re-factors img_create() and moves the core part of
> it into block.c so it can be accessed from qemu as well as
> qemu-img. The second patch adds basic live snapshots support to the
> code, however only snapshots to external QCOW2 images is supported for
> now. QED support should be trivial once the QED patches go into
> upstream.
> 
> The last patch fixes a small gotcha which is present in the old code
> as well. Try to catch cases where a user tries to create an image with
> itself as the backing file. QEMU does 'interesting' things when you do
> this.....
> 
> Many thanks to Kevin for his help with block layer internals!
> 
> Cheers,
> Jes
> 
> 
> Jes Sorensen (3):
>   qemu-img.c: Re-factor img_create()
>   Introduce do_snapshot_blkdev() and monitor command to handle it.
>   Prevent creating an image with the same filename as backing file

This doesn't seem to apply cleanly any more. Can you please rebase
(ideally on top of my block branch)?

Kevin