From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40130 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PSueI-0000YK-7R
	for qemu-devel@nongnu.org; Wed, 15 Dec 2010 11:56:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PSueG-0008G4-Sg
	for qemu-devel@nongnu.org; Wed, 15 Dec 2010 11:56:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:62081)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PSueG-0008Fl-La
	for qemu-devel@nongnu.org; Wed, 15 Dec 2010 11:56:16 -0500
Message-ID: <4D08F32C.1090503@redhat.com>
Date: Wed, 15 Dec 2010 17:56:12 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 1/1] qemu-img.c: Clean up handling of
	image size in img_create()
References: <1291799612-5145-1-git-send-email-Jes.Sorensen@redhat.com>
	<m34oafasoy.fsf@blackfin.pond.sub.org>
In-Reply-To: <m34oafasoy.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org

On 12/15/10 17:47, Markus Armbruster wrote:
> Jes.Sorensen@redhat.com writes:
> 
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> This cleans up the handling of image size in img_create() by parsing
>> the value early, and then only setting it once if a value has been
>> added as the last argument to the command line.
>>
>> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>> ---
>>  qemu-img.c |   14 ++++++++------
>>  1 files changed, 8 insertions(+), 6 deletions(-)
>>
> 
> Patch conflicts with commit c2abccec.

ARGH :(

> This switches parsing of the size argument from parse_option_size() (via
> set_option_parameter()) to strtosz().  I'm fine with that, but:
> 
> * Before:
> 
>     $ qemu-img create xxx xxx
>     Parameter 'size' expects a size
>     You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and terabytes.
>     qemu-img: Image creation needs a size parameter
> 
> * After:
> 
>     $ qemu-img create xxx xxx
>     qemu-img: Image creation needs a size parameter
> 
> Intentional?

This was addressed in the later revision when I introduced strtosz_suffix()

Cheers,
Jes