From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34394 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PSufb-0001Pw-1Q
	for qemu-devel@nongnu.org; Wed, 15 Dec 2010 11:57:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PSufZ-00008J-Pk
	for qemu-devel@nongnu.org; Wed, 15 Dec 2010 11:57:38 -0500
Received: from mx1.redhat.com ([209.132.183.28]:9459)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PSufZ-00008A-Hk
	for qemu-devel@nongnu.org; Wed, 15 Dec 2010 11:57:37 -0500
Message-ID: <4D08F375.3060907@redhat.com>
Date: Wed, 15 Dec 2010 17:57:25 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <1292225579-27320-1-git-send-email-Jes.Sorensen@redhat.com>
	<1292225579-27320-3-git-send-email-Jes.Sorensen@redhat.com>
	<4D08F305.1040503@redhat.com>
In-Reply-To: <4D08F305.1040503@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/3] Introduce do_snapshot_blkdev() and
 monitor command to handle it.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>, armbru@redhat.com, stefanha@linux.vnet.ibm.com

On 12/15/10 17:55, Kevin Wolf wrote:
>> +int do_snapshot_blkdev(Monitor *mon, const QDict *qdict, QObject **ret_data)
>> +{
>> +    const char *device = qdict_get_str(qdict, "device");
>> +    const char *filename = qdict_get_try_str(qdict, "snapshot_file");
>> +    const char *format = qdict_get_try_str(qdict, "format");
>> +    const char format_qcow2[] = "qcow2";
>> +    BlockDriverState *bs;
>> +    BlockDriver *drv, *proto_drv;
>> +    int ret = 0;
>> +    int flags;
>> +
>> +    bs = bdrv_find(device);
>> +    if (!bs) {
>> +        qerror_report(QERR_DEVICE_NOT_FOUND, device);
>> +        ret = -1;
>> +        goto out;
>> +    }
>> +
>> +    if (!format) {
>> +        format = format_qcow2;
>> +    }
>> +
>> +    drv = bdrv_find_format(format);
>> +    if (!drv) {
>> +        qerror_report(QERR_INVALID_BLOCK_FORMAT, format);
>> +        ret = -1;
>> +        goto out;
>> +    }
>> +
>> +    proto_drv = bdrv_find_protocol(filename);
>> +    if (!proto_drv) {
>> +        qerror_report(QERR_INVALID_BLOCK_FORMAT, format);
>> +        ret = -1;
>> +        goto out;
>> +    }
>> +
>> +    ret = bdrv_img_create(filename, format, bs->filename,
>> +                          bs->drv->format_name, NULL, -1, bs->open_flags);
>> +    if (ret) {
>> +        goto out;
>> +    }
>> +
>> +    qemu_aio_flush();
>> +    bdrv_flush(bs);
>> +
>> +    flags = bs->open_flags;
>> +    bdrv_close(bs);
>> +    ret = bdrv_open(bs, filename, flags, drv);
>> +    /*
>> +     * If reopening the image file we just created fails, we really
>> +     * are in trouble :(
>> +     */
>> +    assert(ret == 0);
>> +out:
>> +    if (ret) {
>> +        ret = 1;
> 
> I seem to remember that errors are always -1 for monitor commands.

I mapped it after something else, but admitted I cannot remember where -
can someone clarify?

Cheers,
Jes