From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37439 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PTCwG-0007AN-9b for qemu-devel@nongnu.org; Thu, 16 Dec 2010 07:28:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PTCwF-00029a-04 for qemu-devel@nongnu.org; Thu, 16 Dec 2010 07:28:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PTCwE-00029H-OB for qemu-devel@nongnu.org; Thu, 16 Dec 2010 07:28:02 -0500 Message-ID: <4D0A0610.6040307@redhat.com> Date: Thu, 16 Dec 2010 13:29:04 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1291992477-6388-1-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1291992477-6388-1-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] ide: Register vm change state handler once only List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org Am 10.12.2010 15:47, schrieb Stefan Hajnoczi: > We register the vm change state handler in a PCI BAR map() function. > This function can be called multiple times throughout the lifetime of a > PCI IDE device. This results in duplicate vm change state handlers > being register, none of which are ever unregistered. > > Instead, register the vm change state handler in the device's init > function once and for all. > > piix tested, cmd646 and via not tested. > > Signed-off-by: Stefan Hajnoczi This conflicts with the AHCI patches. Can you rebase on top of the block branch? Kevin