From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49884 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PTDlq-0001vR-8M
	for qemu-devel@nongnu.org; Thu, 16 Dec 2010 08:21:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PTDln-0006oK-JR
	for qemu-devel@nongnu.org; Thu, 16 Dec 2010 08:21:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48897)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PTDln-0006o1-AG
	for qemu-devel@nongnu.org; Thu, 16 Dec 2010 08:21:19 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBGDLIV6006951
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 16 Dec 2010 08:21:18 -0500
Message-ID: <4D0A124C.6080108@redhat.com>
Date: Thu, 16 Dec 2010 14:21:16 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/1] spice: add chardev
References: <1292498949-16933-1-git-send-email-alevy@redhat.com>
In-Reply-To: <1292498949-16933-1-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

On 12/16/10 12:29, Alon Levy wrote:
> Adding a chardev backend for spice, for usage by spice vdagent in
> conjunction with a properly named virtio-serial device.

Usage example would be nice here.

> +#ifdef CONFIG_SPICE
> +#include "spice-qemu-char.h"
> +#endif

#ifdef can be dropped.

> +#ifdef CONFIG_SPICE
> +        {
> +            .name = "name",
> +            .type = QEMU_OPT_STRING,
> +        },{
> +            .name = "debug",
> +            .type = QEMU_OPT_NUMBER,
> +        },
> +#endif

This too.

> @@ -1381,7 +1384,10 @@ Backend is one of:
>   @option{stdio},
>   @option{braille},
>   @option{tty},
> -@option{parport}.
> +@option{parport}
> +#if defined(CONFIG_SPICE)
> +@option{spicevmc}.
> +#endif

This too, documentation should be there unconditionally.

> +//#define SPICE_QEMU_CHAR_USE_IOCTL

Why is this disabled?
Does it depend on the chardev patches from Amit?

> diff --git a/spice-qemu-char.h b/spice-qemu-char.h
> new file mode 100644
> index 0000000..32d5009
> --- /dev/null
> +++ b/spice-qemu-char.h
> @@ -0,0 +1,9 @@
> +#ifndef __SPICE_QEMU_CHAR_H__
> +#define __SPICE_QEMU_CHAR_H__
> +
> +#include "qemu-char.h"
> +
> +CharDriverState *qemu_chr_open_spice(QemuOpts *opts);
> +
> +#endif // __SPICE_QEMU_CHAR_H__
> +

Hmm, maybe add this to ui/qemu-spice.h instead, so we don't clutter the 
tree with lots of tiny includes?

cheers,
   Gerd