From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40112 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PTEgy-0003si-9O
	for qemu-devel@nongnu.org; Thu, 16 Dec 2010 09:20:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PTEgb-00019b-1Q
	for qemu-devel@nongnu.org; Thu, 16 Dec 2010 09:20:03 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39732)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PTEga-00019S-Pb
	for qemu-devel@nongnu.org; Thu, 16 Dec 2010 09:20:01 -0500
Message-ID: <4D0A204D.9050400@redhat.com>
Date: Thu, 16 Dec 2010 15:21:01 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1292503938-10167-1-git-send-email-Jes.Sorensen@redhat.com>
In-Reply-To: <1292503938-10167-1-git-send-email-Jes.Sorensen@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v3 0/4] Re-factor img_create() and add live
	snapshots
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org, armbru@redhat.com, stefanha@linux.vnet.ibm.com

Am 16.12.2010 13:52, schrieb Jes.Sorensen@redhat.com:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
> 
> Hi,
> 
> This set of patches re-factors img_create() and moves the core part of
> it into block.c so it can be accessed from qemu as well as
> qemu-img. The second patch adds basic live snapshots support to the
> code, however only snapshots to external QCOW2 images is supported for
> now. QED support should be trivial once the QED patches go into
> upstream.
> 
> The last patch fixes a small gotcha which is present in the old code
> as well. Try to catch cases where a user tries to create an image with
> itself as the backing file. QEMU does 'interesting' things when you do
> this.....
> 
> Many thanks to Kevin for his help with block layer internals!
> 
> New in v2:
>  - Fix error return value in monitor command
>  - Clarify help message for command
>  - Fix patch conflict against block tree. It's all Stefan's fault :)
>    f8feb11f4d76f390dddc5cc5345abf99f7659a78
> 
> New in v3:
>  - Address issues pointed out by Stefan and Kevin
>  - Additional patch to return proper -errno error values on error in
>    bdrv_img_create() as suggested by Kevin.
> 
> Jes Sorensen (4):
>   qemu-img.c: Re-factor img_create()
>   Introduce do_snapshot_blkdev() and monitor command to handle it.
>   Prevent creating an image with the same filename as backing file
>   bdrv_img_create() use proper errno return values
> 
>  block.c         |  145 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  block.h         |    4 ++
>  blockdev.c      |   62 +++++++++++++++++++++++
>  blockdev.h      |    1 +
>  hmp-commands.hx |   19 +++++++
>  qemu-img.c      |  108 +----------------------------------------
>  6 files changed, 233 insertions(+), 106 deletions(-)

Thanks, applied all to the block branch.

Kevin