From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58077 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PTa5m-0005c5-Kn for qemu-devel@nongnu.org; Fri, 17 Dec 2010 08:11:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PTa5l-0007Vo-GM for qemu-devel@nongnu.org; Fri, 17 Dec 2010 08:11:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PTa5l-0007VW-8p for qemu-devel@nongnu.org; Fri, 17 Dec 2010 08:11:25 -0500 Message-ID: <4D0B61C2.7010106@redhat.com> Date: Fri, 17 Dec 2010 14:12:34 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1292514846-4612-1-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1292514846-4612-1-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2] ide: Register vm change state handler once only List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org Am 16.12.2010 16:54, schrieb Stefan Hajnoczi: > We register the vm change state handler in a PCI BAR map() function. > This function can be called multiple times throughout the lifetime of a > PCI IDE device. This results in duplicate vm change state handlers > being register, none of which are ever unregistered. > > Instead, register the vm change state handler in the device's init > function once and for all. > > piix tested, cmd646 and via not tested. > > Signed-off-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin