From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=32794 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PTabG-0002kK-6l
	for qemu-devel@nongnu.org; Fri, 17 Dec 2010 08:43:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1PTabE-0006kr-Pq
	for qemu-devel@nongnu.org; Fri, 17 Dec 2010 08:43:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:5810)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1PTabE-0006kj-J8
	for qemu-devel@nongnu.org; Fri, 17 Dec 2010 08:43:56 -0500
Message-ID: <4D0B6922.3090401@redhat.com>
Date: Fri, 17 Dec 2010 14:44:02 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in
	make_device_config.sh
References: <1292536325-12881-1-git-send-email-weil@mail.berlios.de>
	<4D0A95BC.8040509@redhat.com>
	<EF8606C6-CED3-45FF-AD68-31C11CFC1977@web.de>
In-Reply-To: <EF8606C6-CED3-45FF-AD68-31C11CFC1977@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 12/17/2010 02:34 PM, Andreas F=E4rber wrote:
>>>
>>> Fix this by removing any \r at end of line.
>>
>> Why isn't cygwin (or whatever you're using) removing it?
>
> I believe Cygwin had an option to choose the line ending style once
> during setup. By default it uses Unix-style line endings.
> If someone edits source files in some Windows editor, the above issue
> seems likely.

Hmm, MSYS is more problematic: the manual says "In the MSYS environment=20
under Windows, `gawk' automatically uses binary mode for reading and=20
writing files. Thus there is no need to use the `BINMODE' variable.=20
This can cause problems with other Unix-like components that have been=20
ported to Windows that expect `gawk' to do automatic translationof=20
`"\r\n"', since it won't.".

> My awk foo is insufficient to ack the patch but if it doesn't break
> Unices it looks reasonable to me.

I'd be worried a bit about Solaris and other proprietary OSes with=20
prehistoric Unix utilities.  Perhaps using \012 instead of \r is better.

Paolo