From: Kevin Wolf <kwolf@redhat.com>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2 0/2] qcow2 cleanups
Date: Fri, 17 Dec 2010 16:17:29 +0100 [thread overview]
Message-ID: <4D0B7F09.2030000@redhat.com> (raw)
In-Reply-To: <1292598160-21698-1-git-send-email-Jes.Sorensen@redhat.com>
Am 17.12.2010 16:02, schrieb Jes.Sorensen@redhat.com:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> Hi,
>
> These two patches tries to clean up the qcow2 code a little. First
> makes the function names consistent, ie. we shouldn't have qcow_
> functions in the qcow2 code. Second tries to add proper errno return
> values to qcow2_open().
>
> New in v2: Fix the bdrv_pread() handling as pointed out by Kevin. Fix
> error messages, and restore a couple of cases to their unreadable
> formatting to avoid formatting changes not directly related to the
> qcow_->qcow2_ rename.
>
> Jes
>
> Jes Sorensen (2):
> block/qcow2.c: rename qcow_ functions to qcow2_
> Add proper -errno error return values to qcow2_open()
>
> block/qcow2-cluster.c | 6 +-
> block/qcow2-snapshot.c | 6 +-
> block/qcow2.c | 248 +++++++++++++++++++++++++++---------------------
> 3 files changed, 145 insertions(+), 115 deletions(-)
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2010-12-17 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 15:02 [Qemu-devel] [PATCH v2 0/2] qcow2 cleanups Jes.Sorensen
2010-12-17 15:02 ` [Qemu-devel] [PATCH 1/2] block/qcow2.c: rename qcow_ functions to qcow2_ Jes.Sorensen
2010-12-17 15:02 ` [Qemu-devel] [PATCH 2/2] Add proper -errno error return values to qcow2_open() Jes.Sorensen
2010-12-17 15:17 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0B7F09.2030000@redhat.com \
--to=kwolf@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).