From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38418 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PTcBd-0000UE-4s for qemu-devel@nongnu.org; Fri, 17 Dec 2010 10:25:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PTcBc-00041c-1H for qemu-devel@nongnu.org; Fri, 17 Dec 2010 10:25:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PTcBb-000412-Qe for qemu-devel@nongnu.org; Fri, 17 Dec 2010 10:25:35 -0500 Message-ID: <4D0B80E2.4070307@redhat.com> Date: Fri, 17 Dec 2010 17:25:22 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError References: <4D088F27.8000909@cn.fujitsu.com> <20101215150911.14e1693f@doriath> <4D08F868.5090100@redhat.com> <20101215152606.078147ad@doriath> <20101215160000.16f85795@doriath> <4D09D5EA.7070000@redhat.com> <20101216084815.3ca77188@doriath> <4D0A0B00.3070108@redhat.com> <20101216110917.646779b7@doriath> <4D0A1016.7060408@redhat.com> <20101216111752.77757c00@doriath> <4D0B011F.8060502@cn.fujitsu.com> <20101217092234.0e43101d@doriath> In-Reply-To: <20101217092234.0e43101d@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, aliguori@us.ibm.com, Lai Jiangshan , kvm@vger.kernel.org, Markus Armbruster On 12/17/2010 01:22 PM, Luiz Capitulino wrote: > > > > I think Avi's suggest is better, and I will use > > "inject-nmi" (without cpu-index argument) to send NMI to all cpus, > > like physical GUI. If some one want to send NMI to a set of cpus, > > he can use "inject-nmi" multiple times. > > His suggestion is to drop _all_ arguments, right Avi? Yes. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.