From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35581 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PTfJ9-000357-F1
	for qemu-devel@nongnu.org; Fri, 17 Dec 2010 13:48:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PTfIf-000733-8T
	for qemu-devel@nongnu.org; Fri, 17 Dec 2010 13:45:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:12248)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PTfIf-00072n-1E
	for qemu-devel@nongnu.org; Fri, 17 Dec 2010 13:45:05 -0500
Message-ID: <4D0BAFEB.9060002@redhat.com>
Date: Fri, 17 Dec 2010 19:46:03 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH v2] ide: Register vm change state handler
	once only
References: <1292514846-4612-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<4D0B61C2.7010106@redhat.com>
	<E7BC1370-FADC-46FC-8805-E0FFFA5B95BA@web.de>
In-Reply-To: <E7BC1370-FADC-46FC-8805-E0FFFA5B95BA@web.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>

Am 17.12.2010 19:35, schrieb Andreas F=E4rber:
> Am 17.12.2010 um 14:12 schrieb Kevin Wolf:
>=20
>> Am 16.12.2010 16:54, schrieb Stefan Hajnoczi:
>>> We register the vm change state handler in a PCI BAR map() function.
>>> This function can be called multiple times throughout the lifetime =20
>>> of a
>>> PCI IDE device.  This results in duplicate vm change state handlers
>>> being register, none of which are ever unregistered.
>>>
>>> Instead, register the vm change state handler in the device's init
>>> function once and for all.
>>>
>>> piix tested, cmd646 and via not tested.
>>>
>>> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>>
>> Thanks, applied to the block branch.
>=20
> This just landed in master and breaks the build due to use of an =20
> undefined variable bm in hw/ide/cmd646.c...

Can you try the patch I just sent?

Kevin