qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wen Congyang <wency@cn.fujitsu.com>
To: qemu-devel <qemu-devel@nongnu.org>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH] disable sigcld handling before calling	pclose()
Date: Mon, 20 Dec 2010 09:25:01 +0800	[thread overview]
Message-ID: <4D0EB06D.6060001@cn.fujitsu.com> (raw)
In-Reply-To: <4D07378B.3050901@cn.fujitsu.com>

At 12/14/2010 05:23 PM, Wen Congyang Write:
> At 2010-12-09 11:41, Wen Congyang Write:
>> When I use the command 'virsh save' to save the domain state,
>> I receive the following error message:
>> operation failed: Migration unexpectedly failed.
>>
>> I debug the qemu by adding some printf(), and find the function
>> pclose() returns -1.
>>
>> I use strace to trace qemu, the log is as the following:
>> ======
>> close(17)                               = 0
>> --- SIGCHLD (Child exited) @ 0 (0) ---
>> wait4(-1, NULL, WNOHANG, NULL)          = 22016
>> rt_sigreturn(0)                         = 0
>> wait4(22016, 0x7fff7f1034fc, 0, NULL)   = -1 ECHILD (No child processes)
>> ======
>>
>> We wait the child twice: one is in signal SIGCHLD handling and the other
>> one is in pclose().
>>
>> We should disable sigcld handling before calling pclose().
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>>
> Ping :)
> 
> 

Ping Again... :)

  reply	other threads:[~2010-12-20  1:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-09  3:41 [Qemu-devel] [PATCH] disable sigcld handling before calling pclose() Wen Congyang
2010-12-14  9:23 ` Wen Congyang
2010-12-20  1:25   ` Wen Congyang [this message]
2010-12-20  6:33     ` Andreas Färber
2010-12-21  2:44       ` Wen Congyang
2010-12-21  4:05       ` [Qemu-devel] [PATCH v2] " Wen Congyang
2011-01-05  2:15         ` Wen Congyang
2011-01-05  9:21         ` [Qemu-devel] " Paolo Bonzini
2011-03-03  3:10         ` [Qemu-devel] " Wen Congyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D0EB06D.6060001@cn.fujitsu.com \
    --to=wency@cn.fujitsu.com \
    --cc=anthony@codemonkey.ws \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).