From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53119 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PUYuc-0000cc-Mf
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 01:07:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <laijs@cn.fujitsu.com>) id 1PUYub-0005q5-Ki
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 01:07:58 -0500
Received: from [222.73.24.84] (port=50578 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laijs@cn.fujitsu.com>) id 1PUYub-0005pW-7e
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 01:07:57 -0500
Message-ID: <4D0EF301.8040903@cn.fujitsu.com>
Date: Mon, 20 Dec 2010 14:09:05 +0800
From: Lai Jiangshan <laijs@cn.fujitsu.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi()
	to QObject, QError
References: <4D088F27.8000909@cn.fujitsu.com>	<20101215150911.14e1693f@doriath>	<4D08F868.5090100@redhat.com>	<20101215152606.078147ad@doriath>	<m3aak7ylp6.fsf@blackfin.pond.sub.org>	<20101215160000.16f85795@doriath>	<4D09D5EA.7070000@redhat.com>	<20101216084815.3ca77188@doriath>	<m3oc8mj5wm.fsf@blackfin.pond.sub.org>	<4D0A0B00.3070108@redhat.com>	<20101216110917.646779b7@doriath>	<4D0A1016.7060408@redhat.com>	<20101216111752.77757c00@doriath>	<4D0B011F.8060502@cn.fujitsu.com>
	<20101217092234.0e43101d@doriath> <4D0B80E2.4070307@redhat.com>
In-Reply-To: <4D0B80E2.4070307@redhat.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, aliguori@us.ibm.com, Markus Armbruster <armbru@redhat.com>, kvm@vger.kernel.org, Luiz Capitulino <lcapitulino@redhat.com>

On 12/17/2010 11:25 PM, Avi Kivity wrote:
> On 12/17/2010 01:22 PM, Luiz Capitulino wrote:
>> >
>> >  I think Avi's suggest is better, and I will use
>> >  "inject-nmi" (without cpu-index argument) to send NMI to all cpus,
>> >  like physical GUI. If some one want to send NMI to a set of cpus,
>> >  he can use "inject-nmi" multiple times.
>>
>> His suggestion is to drop _all_ arguments, right Avi?
> 
> Yes.
> 

We don't need to drop the cpu-index argument,
the upstream tools(libvirt etc.) can just issue "inject-nmi"
command without any argument when need.

Reasons to keep this argument
1) Useful for kernel developer or debuger sending NMI to a special CPU.
2) Share the code with nmi of hmp version. Share the way how to
   use these two commands.(hmp version and qmp version)