From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44811 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PV0uf-0003BP-Is
	for qemu-devel@nongnu.org; Tue, 21 Dec 2010 07:01:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hare@suse.de>) id 1PV0ue-0003Dj-4s
	for qemu-devel@nongnu.org; Tue, 21 Dec 2010 07:01:53 -0500
Received: from cantor2.suse.de ([195.135.220.15]:34425 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hare@suse.de>)
	id 1PV0ud-0003DX-Tf
	for qemu-devel@nongnu.org; Tue, 21 Dec 2010 07:01:52 -0500
Message-ID: <4D10984A.6030809@suse.de>
Date: Tue, 21 Dec 2010 13:06:34 +0100
From: Hannes Reinecke <hare@suse.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 14/15] megasas: LSI Megaraid SAS emulation
References: <1290597370-21365-1-git-send-email-hare@suse.de>	<1290597370-21365-15-git-send-email-hare@suse.de>
	<E589883703AF4312B3962BF4FD4C4120@FSCPC>
In-Reply-To: <E589883703AF4312B3962BF4FD4C4120@FSCPC>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org, kraxel@redhat.com

On 11/25/2010 09:47 PM, Sebastian Herbszt wrote:
> Hannes Reinecke wrote:
>> +static int megasas_scsi_init(PCIDevice *dev)
>> +{
>> +    MPTState *s =3D DO_UPCAST(MPTState, dev, dev);
>> +    uint8_t *pci_conf;
>> +    int i;
>> +
>> +    pci_conf =3D s->dev.config;
>> +
>> +    /* PCI Vendor ID (word) */
>> +    pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_LSI_LOGIC);
>> +    /* PCI device ID (word) */
>> +    pci_config_set_device_id(pci_conf,  PCI_DEVICE_ID_LSI_SAS1078);
>> +    /* PCI subsystem ID */
>> +    pci_set_word(&pci_conf[PCI_SUBSYSTEM_VENDOR_ID], 0x1000);
>=20
> PCI_VENDOR_ID_LSI_LOGIC
>=20
Ok.

>> +    pci_set_word(&pci_conf[PCI_SUBSYSTEM_ID], 0x1013);
>=20
> What is 0x1013?
>=20
That's the device ID for Megaraid SAS 8708EM2.
I'll be adding a #define for it.

>> +    /* PCI base class code */
>> +    pci_config_set_class(pci_conf, PCI_CLASS_STORAGE_RAID);
>> +
>> +    /* PCI latency timer =3D 0 */
>> +    pci_conf[0x0d] =3D 0;
>=20
> PCI_LATENCY_TIMER
>=20
Ok.
>> +    /* Interrupt pin 1 */
>> +    pci_conf[0x3d] =3D 0x01;
>=20
> pci_config_set_interrupt_pin()
>=20
Ok.

Fixed in my megasas git tree. Will be included in the next
round of patches.

Cheers,

Hannes
--=20
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg
GF: Markus Rex, HRB 16746 (AG N=FCrnberg)