From: Avi Kivity <avi@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
kvm@vger.kernel.org, "Richard W. M. Jones" <rjones@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] qemu-kvm: Switch to upstream -enable-kvm semantics
Date: Tue, 21 Dec 2010 17:16:02 +0200 [thread overview]
Message-ID: <4D10C4B2.9000401@redhat.com> (raw)
In-Reply-To: <m339pyyl59.fsf@blackfin.pond.sub.org>
On 12/15/2010 07:57 PM, Markus Armbruster wrote:
> > In the short term, it would be a good idea to modify qemu-kvm to
> > switch the -enable-kvm semantics to match upstream (fail if KVM isn't
> > available).
>
> That's what my patch does.
>
> Additionally, it changes the default to match upstream: KVM disabled.
>
> What do you want changed in my patch?
The 'Additionally' bit. qemu-kvm users rely on the default enabling
kvm. Likely they don't rely on -enable-kvm failing is kvm is not
available (and indeed, they likely expect it to match upstream). So the
patch should only change behaviour when -enable-kvm is specified.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-12-21 15:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m3mxo7ox0v.fsf@blackfin.pond.sub.org>
2010-12-15 17:31 ` [Qemu-devel] Re: [PATCH] qemu-kvm: Switch to upstream -enable-kvm semantics Anthony Liguori
2010-12-15 17:57 ` Markus Armbruster
2010-12-21 15:16 ` Avi Kivity [this message]
2010-12-21 15:41 ` Markus Armbruster
2010-12-21 15:48 ` Avi Kivity
2010-12-21 16:05 ` Markus Armbruster
2010-12-21 16:00 ` Richard W.M. Jones
2010-12-21 16:02 ` Richard W.M. Jones
2010-12-21 16:07 ` Markus Armbruster
2010-12-21 16:56 ` Anthony Liguori
2010-12-21 17:25 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D10C4B2.9000401@redhat.com \
--to=avi@redhat.com \
--cc=armbru@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).