From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60974 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PV3wh-0006lh-FQ for qemu-devel@nongnu.org; Tue, 21 Dec 2010 10:16:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PV3we-00068G-CP for qemu-devel@nongnu.org; Tue, 21 Dec 2010 10:16:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PV3we-000682-4U for qemu-devel@nongnu.org; Tue, 21 Dec 2010 10:16:08 -0500 Message-ID: <4D10C4B2.9000401@redhat.com> Date: Tue, 21 Dec 2010 17:16:02 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4D08FB7D.2010702@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] qemu-kvm: Switch to upstream -enable-kvm semantics List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel , kvm@vger.kernel.org, "Richard W. M. Jones" On 12/15/2010 07:57 PM, Markus Armbruster wrote: > > In the short term, it would be a good idea to modify qemu-kvm to > > switch the -enable-kvm semantics to match upstream (fail if KVM isn't > > available). > > That's what my patch does. > > Additionally, it changes the default to match upstream: KVM disabled. > > What do you want changed in my patch? The 'Additionally' bit. qemu-kvm users rely on the default enabling kvm. Likely they don't rely on -enable-kvm failing is kvm is not available (and indeed, they likely expect it to match upstream). So the patch should only change behaviour when -enable-kvm is specified. -- error compiling committee.c: too many arguments to function