From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41531 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PV4SG-0006Hz-1H
	for qemu-devel@nongnu.org; Tue, 21 Dec 2010 10:48:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1PV4SE-0002Y9-Pc
	for qemu-devel@nongnu.org; Tue, 21 Dec 2010 10:48:47 -0500
Received: from mx1.redhat.com ([209.132.183.28]:63162)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1PV4SE-0002Xn-Gs
	for qemu-devel@nongnu.org; Tue, 21 Dec 2010 10:48:46 -0500
Message-ID: <4D10CC57.3050900@redhat.com>
Date: Tue, 21 Dec 2010 17:48:39 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <m3mxo7ox0v.fsf@blackfin.pond.sub.org>	<4D08FB7D.2010702@codemonkey.ws>	<m339pyyl59.fsf@blackfin.pond.sub.org>
	<4D10C4B2.9000401@redhat.com>
	<m362unkub4.fsf@blackfin.pond.sub.org>
In-Reply-To: <m362unkub4.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] qemu-kvm: Switch to upstream -enable-kvm
	semantics
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, kvm@vger.kernel.org, "Richard W. M. Jones" <rjones@redhat.com>

On 12/21/2010 05:41 PM, Markus Armbruster wrote:
> Avi Kivity<avi@redhat.com>  writes:
>
> >  On 12/15/2010 07:57 PM, Markus Armbruster wrote:
> >>  >   In the short term, it would be a good idea to modify qemu-kvm to
> >>  >   switch the -enable-kvm semantics to match upstream (fail if KVM isn't
> >>  >   available).
> >>
> >>  That's what my patch does.
> >>
> >>  Additionally, it changes the default to match upstream: KVM disabled.
> >>
> >>  What do you want changed in my patch?
> >
> >  The 'Additionally' bit.  qemu-kvm users rely on the default enabling
> >  kvm.  Likely they don't rely on -enable-kvm failing is kvm is not
> >  available (and indeed, they likely expect it to match upstream).  So
> >  the patch should only change behaviour when -enable-kvm is specified.
>
> Like this?
>
> upstream qemu   |  default  |-enable-kvm
> ----------------+-----------+-----------
> KVM available   | disabled  |  enabled
> KVM unavailable | disabled  |    fail
>
> qemu-kvm        |  default  |-enable-kvm|  -no-kvm
> ----------------+-----------+-----------+-----------
> KVM available   |  enabled* |  enabled  |  disabled
> KVM unavailable | disabled  |    fail   |  disabled
>
> * differs from upstream

Yes.

-- 
error compiling committee.c: too many arguments to function