From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40353 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PVCIg-0003cM-IZ
	for qemu-devel@nongnu.org; Tue, 21 Dec 2010 19:11:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jvrao@linux.vnet.ibm.com>) id 1PVCIf-0003Bv-Fa
	for qemu-devel@nongnu.org; Tue, 21 Dec 2010 19:11:26 -0500
Received: from e5.ny.us.ibm.com ([32.97.182.145]:58969)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jvrao@linux.vnet.ibm.com>) id 1PVCIf-0003Bo-D3
	for qemu-devel@nongnu.org; Tue, 21 Dec 2010 19:11:25 -0500
Received: from d01dlp02.pok.ibm.com (d01dlp02.pok.ibm.com [9.56.224.85])
	by e5.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id oBLNmjDA029039
	for <qemu-devel@nongnu.org>; Tue, 21 Dec 2010 18:48:46 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 45D274DE803F
	for <qemu-devel@nongnu.org>; Tue, 21 Dec 2010 19:09:01 -0500 (EST)
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	oBM0BKVP463214
	for <qemu-devel@nongnu.org>; Tue, 21 Dec 2010 19:11:20 -0500
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id oBM0BJb4008446
	for <qemu-devel@nongnu.org>; Tue, 21 Dec 2010 17:11:19 -0700
Message-ID: <4D11422C.3090303@linux.vnet.ibm.com>
Date: Tue, 21 Dec 2010 16:11:24 -0800
From: "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] hw/virtio-9p-local.c: Remove unnecessary
	null char in symlink file
References: <1292908848-8381-1-git-send-email-harsh@linux.vnet.ibm.com>
	<AANLkTimudr3Rxyi2xR04u4S9RpSPTv49iCfKQtcFV9zw@mail.gmail.com>
In-Reply-To: <AANLkTimudr3Rxyi2xR04u4S9RpSPTv49iCfKQtcFV9zw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On 12/20/2010 11:51 PM, Stefan Hajnoczi wrote:
> On Tue, Dec 21, 2010 at 5:20 AM, Harsh Prateek Bora
> <harsh@linux.vnet.ibm.com> wrote:
>> This patch removes the addition of null char in symlink file
>> which is being appended to file in case of mapped security model.
>> Without this patch, the extra null char causes LTP testcase lstat03
>> to fail and hence this fix is required.
> 
> Looks good.
> 
> Related note: local_readlink() with fs_sm == SM_MAPPED reads the
> contents of *any* file.  I don't see a check that the file is actually
> a symlink.  What if an application relies on the EINVAL return value
> when calling readlink() on something that is not a file (not sure how
> this maps through to 9p though)?

Stefan, yes. This is a bug we realized .. fix will be on the way shortly. :)

Thanks,
JV

> 
> Stefan
>