[Qemu-devel] [PATCH] kvm: x86: Remove obsolet SS.RPL/DPL aligment

[Qemu-devel] [PATCH] kvm: x86: Remove obsolet SS.RPL/DPL aligment

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

From: Jan Kiszka <jan.kiszka@siemens.com>

This seems to date back to the days KVM didn't support real mode. The
check is no longer needed and, even worse, is corrupting the guest state
in case SS.RPL != DPL.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 target-i386/kvm.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index b3d7c54..85edacc 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -780,13 +780,6 @@ static int kvm_put_sregs(CPUState *env)
 	    set_seg(&sregs.fs, &env->segs[R_FS]);
 	    set_seg(&sregs.gs, &env->segs[R_GS]);
 	    set_seg(&sregs.ss, &env->segs[R_SS]);
-
-	    if (env->cr[0] & CR0_PE_MASK) {
-		/* force ss cpl to cs cpl */
-		sregs.ss.selector = (sregs.ss.selector & ~3) |
-			(sregs.cs.selector & 3);
-		sregs.ss.dpl = sregs.ss.selector & 3;
-	    }
     }
 
     set_seg(&sregs.tr, &env->tr);
-- 
1.7.1


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

[Qemu-devel] Re: [PATCH] kvm: x86: Remove obsolet SS.RPL/DPL aligment

[Avi Kivity]

On 12/27/2010 04:57 PM, Jan Kiszka wrote:
> From: Jan Kiszka<jan.kiszka@siemens.com>
>
> This seems to date back to the days KVM didn't support real mode. The
> check is no longer needed and, even worse, is corrupting the guest state
> in case SS.RPL != DPL.

Applied to uq/master (nice how obsolete code propagates itself); thanks.

-- 
error compiling committee.c: too many arguments to function