From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60741 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PZjc8-0005Cg-CP
	for qemu-devel@nongnu.org; Mon, 03 Jan 2011 07:34:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1PZjc7-0001dJ-Ek
	for qemu-devel@nongnu.org; Mon, 03 Jan 2011 07:34:16 -0500
Received: from fmmailgate02.web.de ([217.72.192.227]:47787)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1PZjc7-0001d7-4j
	for qemu-devel@nongnu.org; Mon, 03 Jan 2011 07:34:15 -0500
Message-ID: <4D21C244.10901@web.de>
Date: Mon, 03 Jan 2011 13:34:12 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4D21BCF4.6020904@web.de> <4D21C1D0.6060301@redhat.com>
In-Reply-To: <4D21C1D0.6060301@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig3B4580024ED65C08E7EEA3D1"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: qemu vs. kvm: When to flush the coalesced mmio
	buffer?
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig3B4580024ED65C08E7EEA3D1
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Am 03.01.2011 13:32, Avi Kivity wrote:
> On 01/03/2011 02:11 PM, Jan Kiszka wrote:
>> Hi again,
>>
>> another subtle difference between qemu-kvm and upstream:
>>
>> When we leave the guest for an IO window (KVM_RUN returns EINTR or
>> EAGAIN), we call kvm_flush_coalesced_mmio_buffer in qemu-kvm but not i=
n
>> upstream. When version is better? I can't find any rationales in both
>> git logs.
>=20
> We must flush on EINTR, otherwise a live migration can leave some mmios=

> in the source host and not replay them on the destination host.
>=20
> (plus, as Gleb says, if you're in userspace you might as well flush)
>=20

OK, will append a fix to my series.

Thanks,
Jan


--------------enig3B4580024ED65C08E7EEA3D1
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk0hwkQACgkQitSsb3rl5xQOtgCgrpUzMPkT9ICuXP8zKK1OX1xs
F/sAn2JvzlWRyjwdZJ5EnZ0PD1a2O169
=VuJK
-----END PGP SIGNATURE-----

--------------enig3B4580024ED65C08E7EEA3D1--