From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59745 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PZjlm-00009i-Jj for qemu-devel@nongnu.org; Mon, 03 Jan 2011 07:44:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PZjll-0003XK-K2 for qemu-devel@nongnu.org; Mon, 03 Jan 2011 07:44:14 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:57520) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PZjll-0003XA-7C for qemu-devel@nongnu.org; Mon, 03 Jan 2011 07:44:13 -0500 Message-ID: <4D21C49B.6080403@web.de> Date: Mon, 03 Jan 2011 13:44:11 +0100 From: Jan Kiszka MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: jan.kiszka@web.de Subject: [Qemu-devel] [PATCH 18/17] kvm: Flush coalesced mmio buffer on IO window exits List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity , Marcelo Tosatti Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org From: Jan Kiszka We must flush pending mmio writes if we leave kvm_cpu_exec for an IO window. Otherwise we risk to loose those requests when migrating to a different host during that window. Signed-off-by: Jan Kiszka --- kvm-all.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 15d5f32..766a3a7 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -844,6 +844,8 @@ void kvm_cpu_exec(CPUState *env) cpu_single_env = env; kvm_arch_post_run(env, run); + kvm_flush_coalesced_mmio_buffer(); + if (ret == -EINTR || ret == -EAGAIN) { cpu_exit(env); DPRINTF("io window exit\n"); @@ -856,8 +858,6 @@ void kvm_cpu_exec(CPUState *env) abort(); } - kvm_flush_coalesced_mmio_buffer(); - ret = 0; /* exit loop */ switch (run->exit_reason) { case KVM_EXIT_IO: