From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56060 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PZmx9-0000XV-Nx for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:08:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PZmx7-0003cR-ER for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:08:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PZmx7-0003bi-6i for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:08:09 -0500 Message-ID: <4D21F464.1070807@redhat.com> Date: Mon, 03 Jan 2011 18:08:04 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4ffa4f23bc93aa5af90d836986771bb6d9856bf9.1294043582.git.jan.kiszka@web.de> In-Reply-To: <4ffa4f23bc93aa5af90d836986771bb6d9856bf9.1294043582.git.jan.kiszka@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2 17/17] kvm: Drop dependencies on very old capabilities List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Jan Kiszka , Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org On 01/03/2011 10:33 AM, Jan Kiszka wrote: > From: Jan Kiszka > > COALESCED_MMIO, SYNC_MMU, EXT_CPUID, CLOCKSOURCE, NOP_IO_DELAY, PV_MMU - > all these caps predate features on which we already depend at build > time. Moreover, the check for KVM_CAP_EXT_CPUID is unneeded as we > already test& fail is a more recent feature is missing. No. Each test documents a dependency of qemu on a kvm feature. Even though something like SYNC_MMU is unlikely to go away, as long as we depend on it, we require the feature. -- error compiling committee.c: too many arguments to function