From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56307 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PZmyf-0001ru-Jc for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:09:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PZmyX-0003kX-QW for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:09:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PZmyX-0003kS-ID for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:09:37 -0500 Message-ID: <4D21F4BD.8040708@redhat.com> Date: Mon, 03 Jan 2011 18:09:33 +0200 From: Avi Kivity MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2 00/17] [uq/master] Prepare for more qemu-kvm merging List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org On 01/03/2011 10:32 AM, Jan Kiszka wrote: > All previously sent patches against current uq combined, some smaller > tweaks applied, and 4 new patches added. Major news is support for > using up to 16M BIOSes and optional code dump for cpu_dump_state. Those > features are already present qemu-kvm but were reworked to provide > cleaner upstream versions. > Looks reasonable overall. > Based on this series, I've an experimental tree here where I eliminated > another 1500 LOC from qemu-kvm code. Specifically, that tree sets an end > to duplicate KVM and VCPU initialization functions, KVMState copies, and > redundant state saving/loading functions. Will be rolled out after some > more review and testing. Sounds really frightening... this glue code is a real breeding ground for subtle bugs and merge problems. -- error compiling committee.c: too many arguments to function