From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52598 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PZnbV-0003CQ-BT
	for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:49:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1PZnaJ-0003AY-3U
	for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:48:45 -0500
Received: from fmmailgate02.web.de ([217.72.192.227]:55979)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1PZnaI-000393-AN
	for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:48:39 -0500
Message-ID: <4D21FDCB.70504@web.de>
Date: Mon, 03 Jan 2011 17:48:11 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <cover.1294043582.git.jan.kiszka@web.de>	
	<d35c17614fa7646ff48ef57f7922aec01e1044a6.1294043582.git.jan.kiszka@web.de>
	<1294072661.5370.22.camel@mothafucka.localdomain>
In-Reply-To: <1294072661.5370.22.camel@mothafucka.localdomain>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig8A17030AE9E37C3C72165D58"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH v2 14/17] kvm: x86: Introduce kvmclock
 device to save/restore its state
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Marcelo Tosatti <mtosatti@redhat.com>, Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig8A17030AE9E37C3C72165D58
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Am 03.01.2011 17:37, Glauber Costa wrote:
> On Mon, 2011-01-03 at 09:33 +0100, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> If kvmclock is used, which implies the kernel supports it, register a
>> kvmclock device with the sysbus. Its main purpose is to save and resto=
re
>> the kernel state on migration, but this will also allow to visualize i=
t
>> one day.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> CC: Glauber Costa <glommer@redhat.com>
>=20
> Hi Jan.
>=20
> I've just recently posted a patch (not sure what was made from it), tha=
t
> fixes a bug that you reintroduce here.

Hmm, must have missed it.

>=20
> The bug is: if we call KVM_GET_CLOCK ioctl in pre_save, this means that=

> this value will change every time we issue savevm, even if the machine
> is not run in between.
>=20
> Ideally, we'd like to have two consecutive savevms returning the exact
> same thing in that situation.
>=20
> I like the general approach of moving it to sysbus, but please move the=

> ioctl to change state notifiers.

OK, will look into this.

Jan


--------------enig8A17030AE9E37C3C72165D58
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk0h/csACgkQitSsb3rl5xQtPwCfdB5+tRxbFAlYdTkWjTRLDckU
I50AoNCuCdCFaWNKUKnpy6gSRPlk6Vc8
=oguc
-----END PGP SIGNATURE-----

--------------enig8A17030AE9E37C3C72165D58--