From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57804 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PZnjf-0007IG-RD for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:58:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PZng3-000528-Bf for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:54:36 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:51293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PZng2-00051k-MT for qemu-devel@nongnu.org; Mon, 03 Jan 2011 11:54:34 -0500 Message-ID: <4D21FF48.70103@web.de> Date: Mon, 03 Jan 2011 17:54:32 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4ffa4f23bc93aa5af90d836986771bb6d9856bf9.1294043582.git.jan.kiszka@web.de> <4D21F464.1070807@redhat.com> In-Reply-To: <4D21F464.1070807@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig383125BCAB301E62458019CD" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH v2 17/17] kvm: Drop dependencies on very old capabilities List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Jan Kiszka , Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig383125BCAB301E62458019CD Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Am 03.01.2011 17:08, Avi Kivity wrote: > On 01/03/2011 10:33 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> COALESCED_MMIO, SYNC_MMU, EXT_CPUID, CLOCKSOURCE, NOP_IO_DELAY, PV_MMU= - >> all these caps predate features on which we already depend at build >> time. Moreover, the check for KVM_CAP_EXT_CPUID is unneeded as we >> already test& fail is a more recent feature is missing. >=20 > No. Each test documents a dependency of qemu on a kvm feature. Even > though something like SYNC_MMU is unlikely to go away, as long as we > depend on it, we require the feature. >=20 Then at least move all those KVM_CAPs we need at build time into configure. I really see no value in keeping ugly conditional code around, A) because those paths won't be tested and B) none of the CAPs touched here are to pass away without a replacement that will require user space adaption anyway. Jan --------------enig383125BCAB301E62458019CD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk0h/0gACgkQitSsb3rl5xS0OwCdGc2ywuy/PW/SH+75a2BsHcUS cAoAnjs3DO1q05CpOwPZveGCzZfW4ivJ =jZ1p -----END PGP SIGNATURE----- --------------enig383125BCAB301E62458019CD--