From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34287 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pa2T3-0006LL-0T for qemu-devel@nongnu.org; Tue, 04 Jan 2011 03:42:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pa2T1-00065p-PL for qemu-devel@nongnu.org; Tue, 04 Jan 2011 03:42:08 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:52242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pa2T1-00065e-Cc for qemu-devel@nongnu.org; Tue, 04 Jan 2011 03:42:07 -0500 Message-ID: <4D22DD5D.6090106@web.de> Date: Tue, 04 Jan 2011 09:42:05 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4D21F4BD.8040708@redhat.com> In-Reply-To: <4D21F4BD.8040708@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig2F747DA9D3A9D2454ADB8E67" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH v2 00/17] [uq/master] Prepare for more qemu-kvm merging List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2F747DA9D3A9D2454ADB8E67 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Am 03.01.2011 17:09, Avi Kivity wrote: > On 01/03/2011 10:32 AM, Jan Kiszka wrote: >> All previously sent patches against current uq combined, some smaller >> tweaks applied, and 4 new patches added. Major news is support for >> using up to 16M BIOSes and optional code dump for cpu_dump_state. Thos= e >> features are already present qemu-kvm but were reworked to provide >> cleaner upstream versions. >> >=20 > Looks reasonable overall. >=20 >> Based on this series, I've an experimental tree here where I eliminate= d >> another 1500 LOC from qemu-kvm code. Specifically, that tree sets an e= nd >> to duplicate KVM and VCPU initialization functions, KVMState copies, a= nd >> redundant state saving/loading functions. Will be rolled out after som= e >> more review and testing. >=20 > Sounds really frightening... this glue code is a real breeding ground > for subtle bugs and merge problems. =2E..and that's why we are more than late with unifying it into a single code base. After that upcoming cleanup round we will have three major remaining to-d= os: - in-kernel irqchip and PIT support with the subtopics - VAPIC/TPR-patching support - IRQ routing - PCI device assignment - VCPU & IO-thread execution model While I'm not that concerned about the first two as they basically add code that "just" needs to be refactored, the last one is worrying me. We need to find a smart way to morph one into the other. The code is full of subtle differences and is likely quite performance sensitive. Jan --------------enig2F747DA9D3A9D2454ADB8E67 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk0i3V0ACgkQitSsb3rl5xTDuACglukEhO+J0JkqZ4IHlL8HA4GT G1EAnixhHLub7dX8jImyONc+eD1I/d5c =G9m2 -----END PGP SIGNATURE----- --------------enig2F747DA9D3A9D2454ADB8E67--