From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37949 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pa2nN-00013x-M3 for qemu-devel@nongnu.org; Tue, 04 Jan 2011 04:03:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pa2nM-00040g-63 for qemu-devel@nongnu.org; Tue, 04 Jan 2011 04:03:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14208) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pa2nL-00040T-Uy for qemu-devel@nongnu.org; Tue, 04 Jan 2011 04:03:08 -0500 Message-ID: <4D22E21F.1040908@redhat.com> Date: Tue, 04 Jan 2011 11:02:23 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4D21F4BD.8040708@redhat.com> <4D22DD5D.6090106@web.de> In-Reply-To: <4D22DD5D.6090106@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2 00/17] [uq/master] Prepare for more qemu-kvm merging List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org On 01/04/2011 10:42 AM, Jan Kiszka wrote: > > > > Sounds really frightening... this glue code is a real breeding ground > > for subtle bugs and merge problems. > > ...and that's why we are more than late with unifying it into a single > code base. > > After that upcoming cleanup round we will have three major remaining to-dos: > - in-kernel irqchip and PIT support with the subtopics > - VAPIC/TPR-patching support > - IRQ routing > - PCI device assignment > - VCPU& IO-thread execution model > > While I'm not that concerned about the first two as they basically add > code that "just" needs to be refactored, the last one is worrying me. We > need to find a smart way to morph one into the other. The code is full > of subtle differences and is likely quite performance sensitive. Agreed on all counts. -- error compiling committee.c: too many arguments to function