From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42175 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pa59j-00074W-CZ
	for qemu-devel@nongnu.org; Tue, 04 Jan 2011 06:34:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1Pa59i-00063K-5h
	for qemu-devel@nongnu.org; Tue, 04 Jan 2011 06:34:23 -0500
Received: from fmmailgate03.web.de ([217.72.192.234]:49953)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1Pa59h-000639-Ci
	for qemu-devel@nongnu.org; Tue, 04 Jan 2011 06:34:22 -0500
Message-ID: <4D2305B9.4010706@web.de>
Date: Tue, 04 Jan 2011 12:34:17 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <cover.1294129949.git.jan.kiszka@web.de>	
	<defb249386b08f440163c10d5d815586ef1023ec.1294129949.git.jan.kiszka@web.de>
	<1294139314.5370.34.camel@mothafucka.localdomain>
In-Reply-To: <1294139314.5370.34.camel@mothafucka.localdomain>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig42E64917BDC6EB60F2ECF998"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH v3 15/21] kvm: x86: Introduce kvmclock
 device to save/restore its state
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig42E64917BDC6EB60F2ECF998
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Am 04.01.2011 12:08, Glauber Costa wrote:
> On Tue, 2011-01-04 at 09:32 +0100, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> If kvmclock is used, which implies the kernel supports it, register a
>> kvmclock device with the sysbus. Its main purpose is to save and resto=
re
>> the kernel state on migration, but this will also allow to visualize i=
t
>> one day.
>=20
> I would prefer having no pre-save, and doing the ioctl in the state
> change handler. But I won't nitpick about that, if the maintainers thin=
k
> this is okay, all the rest of the patch looks fine as well.

I did this for a reason: to be able to obtain the current clock state
even while the vm is running. It's cleaner IMHO.

Jan


--------------enig42E64917BDC6EB60F2ECF998
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk0jBboACgkQitSsb3rl5xTkAACgpXICrzGqEb9YU9QrnctcBdav
oWkAn0TzI/CHAcpu227A5YmNS40DDdg9
=Xgrw
-----END PGP SIGNATURE-----

--------------enig42E64917BDC6EB60F2ECF998--