From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35643 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PaOmz-00009x-In for qemu-devel@nongnu.org; Wed, 05 Jan 2011 03:32:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PaOmz-0002BU-Bm for qemu-devel@nongnu.org; Wed, 05 Jan 2011 03:32:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PaOmz-0002BA-26 for qemu-devel@nongnu.org; Wed, 05 Jan 2011 03:32:13 -0500 Message-ID: <4D242C81.5000604@redhat.com> Date: Wed, 05 Jan 2011 10:32:01 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Add VMX cpuid feature to qemu64 References: <20110104150631.GA24238@fermat.math.technion.ac.il> <8153A341-349B-4A89-A737-DCF5187FFE23@suse.de> <20110104213907.GA6364@fermat.math.technion.ac.il> <50D01580-FB08-459A-84B9-7C8AA8190AFD@suse.de> <20110105081737.GA23681@fermat.math.technion.ac.il> In-Reply-To: <20110105081737.GA23681@fermat.math.technion.ac.il> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nadav Har'El Cc: Alexander Graf , qemu-devel@nongnu.org On 01/05/2011 10:17 AM, Nadav Har'El wrote: > On Tue, Jan 04, 2011, Alexander Graf wrote about "Re: [Qemu-devel] [PATCH] Add VMX cpuid feature to qemu64": > > If qemu-kvm still uses the "qemu64" type, that's plainly a bug :). It really should use -cpu kvm64 / kvm32 as default. > > When I run qemu-kvm's qemu-system-x86_64, and look at the CPU I get in the > guest, I the CPU is clearly "QEMU Virtual CPU version 0.13.50" (qemu64) and > not "Common KVM processor" (kvm64) the "-enable-kvm" option doesn't appear to > change anything. Could this have always been a bug, which remained hidden > in plain sight? :-) > > If I send a patch to default to kvm64, not qemu64, when KVM is being used, > would that be acceptable by all parties involved (KVM people and QEMU people)? > The intent of kvm64/qemu64 is to provide some feature stability, so that when you run a guest with those cpu types, you get something expected. So adding to them isn't a good idea. I think we'd be fine with -cpu host and -cpu qemu64,+vmx enabling vmx support. -- error compiling committee.c: too many arguments to function